Move 'update' pipeline option to correct interface

Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/1f31d4d5
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/1f31d4d5
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/1f31d4d5

Branch: refs/heads/master
Commit: 1f31d4d5980619916a39c70a0af046fc4235b71e
Parents: c9e5525
Author: Scott Wegner <[email protected]>
Authored: Mon Feb 29 15:24:49 2016 -0800
Committer: Luke Cwik <[email protected]>
Committed: Wed Mar 2 08:41:32 2016 -0800

----------------------------------------------------------------------
 .../sdk/options/DataflowPipelineDebugOptions.java      |  4 ++++
 .../dataflow/sdk/options/DataflowPipelineOptions.java  | 13 +++++++++++++
 2 files changed, 17 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/1f31d4d5/sdk/src/main/java/com/google/cloud/dataflow/sdk/options/DataflowPipelineDebugOptions.java
----------------------------------------------------------------------
diff --git 
a/sdk/src/main/java/com/google/cloud/dataflow/sdk/options/DataflowPipelineDebugOptions.java
 
b/sdk/src/main/java/com/google/cloud/dataflow/sdk/options/DataflowPipelineDebugOptions.java
index e94b56d..3ceec89 100644
--- 
a/sdk/src/main/java/com/google/cloud/dataflow/sdk/options/DataflowPipelineDebugOptions.java
+++ 
b/sdk/src/main/java/com/google/cloud/dataflow/sdk/options/DataflowPipelineDebugOptions.java
@@ -172,11 +172,15 @@ public interface DataflowPipelineDebugOptions extends 
PipelineOptions {
 
   /**
    * Whether to update the currently running pipeline with the same name as 
this one.
+   * 
+   * @deprecated This property is replaced by @{link 
DataflowPipelineOptions#getUpdate()}
    */
   @JsonIgnore
+  @Deprecated
   @Description("If set, replace the existing pipeline with the name specified 
by --jobName with "
       + "this pipeline, preserving state.")
   boolean getUpdate();
+  @Deprecated
   void setUpdate(boolean value);
 
   /**

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/1f31d4d5/sdk/src/main/java/com/google/cloud/dataflow/sdk/options/DataflowPipelineOptions.java
----------------------------------------------------------------------
diff --git 
a/sdk/src/main/java/com/google/cloud/dataflow/sdk/options/DataflowPipelineOptions.java
 
b/sdk/src/main/java/com/google/cloud/dataflow/sdk/options/DataflowPipelineOptions.java
index a0f188a..1aa4342 100644
--- 
a/sdk/src/main/java/com/google/cloud/dataflow/sdk/options/DataflowPipelineOptions.java
+++ 
b/sdk/src/main/java/com/google/cloud/dataflow/sdk/options/DataflowPipelineOptions.java
@@ -92,6 +92,19 @@ public interface DataflowPipelineOptions extends
   void setJobName(String value);
 
   /**
+   * Whether to update the currently running pipeline with the same name as 
this one.
+   */
+  @Override
+  @SuppressWarnings("deprecation") // base class member deprecated in favor of 
this one.
+  @Description(
+      "If set, replace the existing pipeline with the name specified by 
--jobName with "
+          + "this pipeline, preserving state.")
+  boolean getUpdate();
+  @Override
+  @SuppressWarnings("deprecation") // base class member deprecated in favor of 
this one.
+  void setUpdate(boolean value);
+
+  /**
    * Returns a normalized job name constructed from {@link 
ApplicationNameOptions#getAppName()}, the
    * local system user name (if available), and the current time. The 
normalization makes sure that
    * the job name matches the required pattern of [a-z]([-a-z0-9]*[a-z0-9])? 
and length limit of 40

Reply via email to