Repository: incubator-beam Updated Branches: refs/heads/master a13dd2910 -> 6ba288d67
Fix AfterWatermark Early and Late javadoc The docs were reversed - the late trigger is only considered after the watermark has passed the end of the window, and the early trigger only before the watermark has passed the end of the window. Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/328a1472 Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/328a1472 Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/328a1472 Branch: refs/heads/master Commit: 328a14728743746381d6221e219ec25b7bcfad13 Parents: a13dd29 Author: Thomas Groh <[email protected]> Authored: Wed Mar 16 13:28:02 2016 -0700 Committer: Thomas Groh <[email protected]> Committed: Wed Mar 16 13:28:02 2016 -0700 ---------------------------------------------------------------------- .../cloud/dataflow/sdk/transforms/windowing/AfterWatermark.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/328a1472/sdk/src/main/java/com/google/cloud/dataflow/sdk/transforms/windowing/AfterWatermark.java ---------------------------------------------------------------------- diff --git a/sdk/src/main/java/com/google/cloud/dataflow/sdk/transforms/windowing/AfterWatermark.java b/sdk/src/main/java/com/google/cloud/dataflow/sdk/transforms/windowing/AfterWatermark.java index da16db9..fac2c28 100644 --- a/sdk/src/main/java/com/google/cloud/dataflow/sdk/transforms/windowing/AfterWatermark.java +++ b/sdk/src/main/java/com/google/cloud/dataflow/sdk/transforms/windowing/AfterWatermark.java @@ -80,7 +80,7 @@ public class AfterWatermark<W extends BoundedWindow> { public interface AfterWatermarkEarly<W extends BoundedWindow> extends TriggerBuilder<W> { /** * Creates a new {@code Trigger} like the this, except that it fires repeatedly whenever - * the given {@code Trigger} fires before the watermark has passed the end of the window. + * the given {@code Trigger} fires after the watermark has passed the end of the window. */ TriggerBuilder<W> withLateFirings(OnceTrigger<W> lateTrigger); } @@ -91,7 +91,7 @@ public class AfterWatermark<W extends BoundedWindow> { public interface AfterWatermarkLate<W extends BoundedWindow> extends TriggerBuilder<W> { /** * Creates a new {@code Trigger} like the this, except that it fires repeatedly whenever - * the given {@code Trigger} fires after the watermark has passed the end of the window. + * the given {@code Trigger} fires before the watermark has passed the end of the window. */ TriggerBuilder<W> withEarlyFirings(OnceTrigger<W> earlyTrigger); }
