GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/70

    Replace unambiguous of `throw Throwables.propagate` with definition

    In the SDK the path taken by `Throwables.propagate` is always statically 
known, and the inlined logic is more explicit and readable:
    
     - If an exception e is already a checked exception, 
`Throwables.propagate(e)`
       is the same as `throw new RuntimeException(e)`.
     - If an exception e is already a `RuntimeException` or Error,
       `Throwables.propagate(e)` is the same as `throw e`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam 
throwables-propagate

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/70.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #70
    
----
commit 5c13f33e6b3ca5178bb88ffb957ecaf1d7f2363a
Author: Kenneth Knowles <k...@google.com>
Date:   2016-03-23T16:29:45Z

    Replace unambiguous of `throw Throwables.propagate` with definition
    
    In the SDK the path taken by Throwables.propagate is always statically
    known, and the inlined logic is more explicit and readable:
    
     - If an exception e is already a checked exception, Throwables.propagate(e)
       is the same as `throw new RuntimeException(e)`.
     - If an exception e is already a RuntimeException or Error,
       Throwables.propagate(e) is the same as `throw e`.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to