[
https://issues.apache.org/jira/browse/BEAM-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212378#comment-15212378
]
Luke Cwik commented on BEAM-136:
--------------------------------
I double checked that the meta-inf services specification in the flink runner
jar contains entries for flink runner and flink options
lcwik@lcwik0:~/git/incubator-beam/runners/flink/runner/target$ cat
META-INF/services/com.google.cloud.dataflow.sdk.options.PipelineOptionsRegistrar
org.apache.beam.runners.flink.FlinkRunnerRegistrar$Options
lcwik@lcwik0:~/git/incubator-beam/runners/flink/runner/target$ cat
META-INF/services/com.google.cloud.dataflow.sdk.runners.PipelineRunnerRegistrar
org.apache.beam.runners.flink.FlinkRunnerRegistrar$Runner
lcwik@lcwik0:~/git/incubator-beam/runners/flink/runner/target$ jar tvf
flink-runner_2.10-0.1.0-incubating-SNAPSHOT.jar
...
1100 Fri Mar 25 12:50:34 PDT 2016
org/apache/beam/runners/flink/FlinkRunnerRegistrar$Options.class
27598 Fri Mar 25 13:00:46 PDT 2016 META-INF/DEPENDENCIES
191 Fri Mar 25 13:00:46 PDT 2016 META-INF/NOTICE
58 Fri Mar 25 12:50:34 PDT 2016
META-INF/services/com.google.cloud.dataflow.sdk.runners.PipelineRunnerRegistrar
59 Fri Mar 25 12:50:34 PDT 2016
META-INF/services/com.google.cloud.dataflow.sdk.options.PipelineOptionsRegistrar
11358 Fri Mar 25 13:00:46 PDT 2016 META-INF/LICENSE
1231 Fri Mar 25 12:50:34 PDT 2016 log4j.properties
0 Fri Mar 25 13:01:00 PDT 2016 META-INF/maven/
0 Fri Mar 25 13:01:00 PDT 2016 META-INF/maven/org.apache.beam/
0 Fri Mar 25 13:01:00 PDT 2016
META-INF/maven/org.apache.beam/flink-runner_2.10/
4438 Fri Mar 25 12:02:44 PDT 2016
META-INF/maven/org.apache.beam/flink-runner_2.10/pom.xml
137 Fri Mar 25 13:00:54 PDT 2016
META-INF/maven/org.apache.beam/flink-runner_2.10/pom.properties
As long as the user includes the flink runner jar on the command line, they
should get it for free since java's serviceloader is responsible for finding
all such entries in all jars on the classpath:
https://docs.oracle.com/javase/7/docs/api/java/util/ServiceLoader.html
> PipelineOptionsFactory should detect all runners
> ------------------------------------------------
>
> Key: BEAM-136
> URL: https://issues.apache.org/jira/browse/BEAM-136
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Daniel Halperin
> Assignee: Thomas Groh
> Priority: Minor
>
> Even with flink-runner jar on classpath, we didn't find it.
> See linked thread here:
> http://mail-archives.apache.org/mod_mbox/incubator-beam-user/201603.mbox/%3CCAA8k_FLekCURJKYO8qab%3DR%3DG-sRrTmYc7_NQXcrY1kHyATAtBw%40mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
