GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/106
[BEAM-22] Clean up InProcess Read Evaluators
These are a couple of minor improvements to BoundedReadEvaluator
and UnboundedReadEvaluator that enables splitting a source at
evaluation time, as well as minor code cleanup.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam
ippr_cleaner_read_evaluators
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #106
----
commit b83328c5b763c1974ad5a84d2870753e2078d1ee
Author: Thomas Groh <[email protected]>
Date: 2016-03-31T17:40:37Z
Explicitly track the Source a ReadEvaluator is using
This permits use of sources that are not the initial source used in the
transform. BoundedSource#splitIntoBundles and
UnboundedSource#generateInitialSplits generate multiple source objects
for the same transform in order to permit parallelism.
commit 2f756cc06967afa6d49aae54296568e70145551d
Author: Thomas Groh <[email protected]>
Date: 2016-03-31T17:43:56Z
Use proper scoping, interfaces in BoundedReadEvaluator
Use BoundedReader instead of Reader.
contentsRemaining should be method-scoped not instance-scoped.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
