[ 
https://issues.apache.org/jira/browse/BEAM-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253861#comment-15253861
 ] 

ASF GitHub Bot commented on BEAM-213:
-------------------------------------

GitHub user amitsela opened a pull request:

    https://github.com/apache/incubator-beam/pull/230

    [BEAM-213] Fix README to use refactored package names and use AutoService 
for Registrar

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amitsela/incubator-beam BEAM-213

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/230.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #230
    
----
commit a1b77445b5c7d0c60415a9db8d943d6ede9da6b1
Author: Sela <[email protected]>
Date:   2016-04-22T11:33:46Z

    Remove specific registrar classes and service files

commit 3f662069448bc38f03b735a8152e78181c469c54
Author: Sela <[email protected]>
Date:   2016-04-22T11:34:53Z

    Add dependency on AutoService

commit 5860a3c0762fe4f7a04eac4f7344fcd4b561c2da
Author: Sela <[email protected]>
Date:   2016-04-22T11:35:19Z

    Add SparkRunnerRegistrar as a runner specific registrar that uses 
AutoService

commit bd65f2687b601794ea29efff330f9bdec1e62bce
Author: Sela <[email protected]>
Date:   2016-04-22T11:36:33Z

    Add a unit test for the SparkRunnerRegistrar

commit eb65c1565867ffae38033628cdd4b3b029535908
Author: Sela <[email protected]>
Date:   2016-04-21T19:48:14Z

    Update README according to dataflow->beam package rename

----


> Fix README to use refactored package names and use AutoService for Registrar
> ----------------------------------------------------------------------------
>
>                 Key: BEAM-213
>                 URL: https://issues.apache.org/jira/browse/BEAM-213
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-spark
>            Reporter: Amit Sela
>            Assignee: Amit Sela
>
> Change mainClass to org.apache.beam.examples.WordCount
> and runner to the fully qualified runner class



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to