[
https://issues.apache.org/jira/browse/BEAM-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15261091#comment-15261091
]
ASF GitHub Bot commented on BEAM-77:
------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/256
[BEAM-77] Move InProcessRunner to runners/inprocess
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
I believe since the `DirectPipelineRunner` is still in place, this safe to
do immediately. Then we can begin to run all tests on this runner in the same
way we do for all runners, gaining coverage of both. Finally, we can simply
delete `DirectPipelineRunner` which will expose any tests that require the
`NeedsRunner` category.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam NeedsRunner
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/256.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #256
----
commit 707f3a5db54d1d89ca61ee05058ea370d38a1db5
Author: Kenneth Knowles <[email protected]>
Date: 2016-04-27T22:20:09Z
Add NeedsRunner category tag
commit 1e93662ad2e5b13fd765fb7b5b16e02add584198
Author: Kenneth Knowles <[email protected]>
Date: 2016-04-27T22:01:48Z
Move InProcessRunner to its own module
----
> Reorganize Directory structure
> ------------------------------
>
> Key: BEAM-77
> URL: https://issues.apache.org/jira/browse/BEAM-77
> Project: Beam
> Issue Type: Task
> Components: project-management
> Reporter: Frances Perry
> Assignee: Jean-Baptiste Onofré
>
> Now that we've done the initial Dataflow code drop, we will restructure
> directories to provide space for additional SDKs and Runners.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
