GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/277
Port batch Flink GroupByKey to GroupByKeyViaGroupByKeyOnly
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
These are some moderately useful preliminaries that came out of a quick
attempt to try out the `RunnableOnService` tests with the Flink runner. The
attempt got a bit stuck, but I figured these alteration might be useful either
way.
If you are curious, translation seems to just not be invoked in my
configuration, which you can see in the next couple commits on my branch
[flink-integration]
(https://github.com/kennknowles/incubator-beam/commits/flink-integration)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam flink-GBK
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/277.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #277
----
commit b1774d02e35737128e99730538c448f1ef3e955b
Author: Kenneth Knowles <[email protected]>
Date: 2016-05-02T21:28:05Z
Port Flink batch translator to GroupByKeyViaGroupByKeyOnly
The current Flink batch translation ignores windows. This is consistent
with the requirements of GroupByKeyOnly. This change ports the runner
to the expansion of GroupByKey to a GroupByKeyOnly operation followed
by a GroupAlsoByWindow operation.
commit 343638763aa3d6ebe2441d442d8ef99c52326a31
Author: Kenneth Knowles <[email protected]>
Date: 2016-05-02T21:29:30Z
Add temporary Window.Bound translator to Flink batch
This adds a Window.Bound translator that matches Flink streaming. It
depends on deprecated privileged methods of DoFn.ProcessContext. But
this is the status quo for most runners anyhow, and we have a plan
for migrating everything away from it.
This restores windowing support to the batch runner, and opens
the door to using GroupByKeyViaGroupByKeyOnly, for which Flink already
has the needed capabilities.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
