[
https://issues.apache.org/jira/browse/BEAM-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269544#comment-15269544
]
ASF GitHub Bot commented on BEAM-248:
-------------------------------------
GitHub user swegner opened a pull request:
https://github.com/apache/incubator-beam/pull/280
[BEAM-248] Add display data to additional PTransforms
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/swegner/incubator-beam displaydata-leaves
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/280.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #280
----
commit 676f6fe8715444a8bf1c614de7322557a6f9de72
Author: Scott Wegner <[email protected]>
Date: 2016-05-03T16:28:21Z
Test utility for display data in a pipeline runner
DisplayDataEvaluator is useful for validating how PTransform
display data is surfaced in the context of a Pipeline and runner.
commit f5e167bbea1ffced370dffab8af2697fad157728
Author: Scott Wegner <[email protected]>
Date: 2016-05-03T16:33:55Z
Fix Combine transform primitive display data
commit 978068c2fb754986cb86f412c1e85eaf5ee30f7b
Author: Scott Wegner <[email protected]>
Date: 2016-05-03T18:16:51Z
Add display data for MapElements transform
----
> Register DisplayData from anonymous implementation PTransforms
> --------------------------------------------------------------
>
> Key: BEAM-248
> URL: https://issues.apache.org/jira/browse/BEAM-248
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Scott Wegner
> Assignee: Scott Wegner
>
> Most SDK PTransforms are implemented in terms of lower-level PTransforms,
> often with anonymous user-fn implementations at the leaf-level. Currently
> display data is only being registered on the composite node and not within
> the anonymous implementation. As a result, the details are lost.
> We should register display data both in the composite and internal leaf
> nodes, particularly when the implementation is anonymous.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
