GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/287

    Removes spurious re-builds of sdks/java/core

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    We mutate a source file during maven pre-processing, so the build is always 
stale. It seems we want to have a timestamp in the jar. We need to find a 
better way to do this anyhow so the build isn't always rebuilding pointlessly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam sdk-timestamp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/287.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #287
    
----
commit 48f5b7b0866db7daac5822b1deee94d9a7960df4
Author: Kenneth Knowles <k...@google.com>
Date:   2016-05-04T04:27:44Z

    Remove timestamp in source that caused spurious builds

commit 95a167b08c6564c3b3aae55e7f87e5bf9816178e
Author: Kenneth Knowles <k...@google.com>
Date:   2016-05-04T04:30:51Z

    Exclude package-info.java from compiled sources list
    
    This is a workaround for [MCOMPILER-205], which causes
    maven-compiler-plugin to always detect stale sources due to sources
    that do not create a class file, such as package-info.java.
    
    An alternative workaround is to add dummy annotations to all
    package-info.java files, which will induce package-info.class
    files.
    
    [MCOMPILER-205](https://issues.apache.org/jira/browse/MCOMPILER-205)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to