GitHub user rangadi opened a pull request:
https://github.com/apache/incubator-beam/pull/290
- after shutting down consumer poll thread (and offset updater thread),
wait for them to actually exit.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
- handle a possible race between poll thread and close().
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rangadi/incubator-beam shutdown
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/290.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #290
----
commit 8cdb8fbd22ec4e1d806417ef28d8a69fcdf6a1a5
Author: Raghu Angadi <[email protected]>
Date: 2016-05-05T01:34:20Z
- after shutting down, wait for the threads to actually finish
- handle a possible race between poll thread and close().
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
