GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/319
[BEAM-22] Enable RunnableOnService Tests
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Not ready for review. Publishing PR to hook into Travis and Jenkins.
Update runners/direct-java/pom.xml to enable the RunnableOnService
tests phase.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam enable_ros_tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/319.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #319
----
commit d1796ba6fecb8423e563fcdf66946beda79e52c6
Author: Thomas Groh <[email protected]>
Date: 2016-05-09T22:47:27Z
Minor checkArgument style fix
commit f0e38fd170949f27d4794113e4bcb2077ffe88a6
Author: Thomas Groh <[email protected]>
Date: 2016-05-10T18:27:37Z
Use an AtomicReference in InProcessSideInputContainer
This fixes a TOCTOU race in the contents updating logic, where the
determination that the current pane should replace the contents of the
side input and the replacement is not a single atomic operation. Using
AtomicReference allows the use of compareAndSet to ensure that the
replacement can only occur on the pane that the decision to replace was
made with.
Fixes a race where a pane could be the latest, and replace a
pane, but would be lost due to an earlier pane being written between the
invalidation and loading of contents.
Fixes a race where a reader can incorrectly read an empty iterable as
the contents of a PCollectionView, due to occuring between the
invalidate and reload steps.
commit e06e449e3762a48404d0407babaff440ebfa416e
Author: Thomas Groh <[email protected]>
Date: 2016-05-10T20:22:20Z
Cache read SideInput Contents in the InProcessSideInputContainer
This ensures that while processing a bundle all elements see the same
contents for any SideInput Window.
commit 8ff1d79474f3d114381b924fa61aa46bd7b935db
Author: Thomas Groh <[email protected]>
Date: 2016-05-10T20:36:21Z
Enable RunnableOnService tests for the Direct Runner
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
