GitHub user swegner opened a pull request: https://github.com/apache/incubator-beam/pull/355
[BEAM-117] Fix bug in PipelineOptions DisplayData serialization Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- In the code for populating display data for `PipelineOptions` in the serialized JSON, we had a bug in `ProxyInvocationHandler.Serializer` where it was not checking for null values from previously-deserialized JSON values. As a result, a null value in the JSON would cause us to throw and block pipelines from running. This PR fixes a number of issues: * Properly handle null JSON values in `ProxyInvocatinHandler.Serializer` * Establish a common pattern for handling errors during display data collection, via `DisplayData.from(Throwable)` * Implement resiliency pattern in `ProxyInvocationHandler.Serializer` so bugs in `PipelineOptions` serialization do not prevent running pipelines. You can merge this pull request into a Git repository by running: $ git pull https://github.com/swegner/incubator-beam displaydata-resiliency Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/355.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #355 ---- commit 8ffeb3da894ee5e25a54f7faa8faeff8fe1ae98f Author: Scott Wegner <sweg...@google.com> Date: 2016-05-19T16:17:37Z Fix bug in PipelineOptions DisplayData serialization ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---