GitHub user swegner opened a pull request: https://github.com/apache/incubator-beam/pull/357
[BEAM-176] Add FindBugs analysis to the build Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- FindBugs is a static analysis tool which looks for common coding issues in Java code. See: http://findbugs.sourceforge.net/ This PR integrates FindBugs into the build process using findbugs-maven-plugin, and subscribes java-sdk-all for analysis. The codebase currently generates many Findbugs issues, which have been added in the findbugs-filter.xml file as a baseline. These issues should be triaged and fixed over time. There will be some cases where we choose to ignore issues reported by FindBugs. In such a case, the issue should be suppressed in code via the `@SuppressFBWarnings` annotation with a comment describing why it is suppressed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/swegner/incubator-beam findbugs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/357.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #357 ---- commit 10bd439e0650c183bb667366399444ef0998bd04 Author: Scott Wegner <sweg...@google.com> Date: 2016-05-16T22:44:45Z Add FindBugs analysis to the build FindBugs is a static analysis tool which looks for common coding issues in Java code. See: http://findbugs.sourceforge.net/ This commit integrates FindBugs into the build process using findbugs-maven-plugin, and subscribes java-sdk-all for analysis. The codebase currently generates many Findbugs issues, which have been added in the findbugs-filter.xml file as a baseline. These issues should be triaged and fixed over time. There will be some cases where we choose to ignore issues reported by FindBugs. In such a case, the issue should be suppressed in code via the @SuppressFBWarnings annotation with a comment describing why it is suppressed. commit f8706b536788ebbe415648a7658a9bd599ada7ad Author: Scott Wegner <sweg...@google.com> Date: 2016-05-16T23:39:39Z Disable not useful DM_STRING_CTOR warnings These seem to pop up for normal string concatenation. commit 195bd8e435eeade822e5d9a0798df633c23a2149 Author: Scott Wegner <sweg...@google.com> Date: 2016-05-19T18:47:02Z Fix AvroCoder log message null reference. commit feaaac1492977f06bcc2dc5980ca7a3f63dacffe Author: Scott Wegner <sweg...@google.com> Date: 2016-05-19T19:53:23Z Suppress FindBugs warning for checked null dereference commit 94b79eb8a11e107ed3a78873bc050a9d33351913 Author: Scott Wegner <sweg...@google.com> Date: 2016-05-19T19:58:34Z Disable not nuseful SE_NO_SERIALVERSIONID warnings ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---