GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/362
Remove inheritance from Create.TimestampedValues
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Previously, Create.TimestampedValues extended Create.Values. This
actually resulted in confusing behavior in one runner because
Create.Values was overridden using `instanceof` checks, which
accidentally pulled in Create.TimestampedValues.
Now Create.TimeStampedValues is a simple composite transform.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam
CreateTimestampedValues
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/362.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #362
----
commit f0e125871d9ca6da9c8597a2216c3b44b9e85345
Author: Kenneth Knowles <[email protected]>
Date: 2016-05-20T03:28:36Z
Remove inheritance from Create.TimestampedValues
Previously, Create.TimestampedValues extends Create.Values. This
actually resulted in confusing behavior in one runner because
Create.Values was overridden using `instanceof` checks, which
accidentally pulled in Create.TimestampedValues.
Now Create.TimeStampedValues is a simple composite transform.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
