[
https://issues.apache.org/jira/browse/BEAM-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295352#comment-15295352
]
ASF GitHub Bot commented on BEAM-53:
------------------------------------
GitHub user mshields822 opened a pull request:
https://github.com/apache/incubator-beam/pull/371
[BEAM-53] Mirror some DataflowJavaSDK pubsub fixes
Forward port from
https://github.com/GoogleCloudPlatform/DataflowJavaSDK/pull/281
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mshields822/incubator-beam pubsub-fiddles
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/371.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #371
----
commit c87a19b38e51b2e15689b154089ec93da1a8c7ae
Author: Mark Shields <[email protected]>
Date: 2016-05-21T04:22:08Z
s/Apiary/Json/g
commit 0a48cfa5479310fbdb212dce8c84a140517a7f66
Author: Mark Shields <[email protected]>
Date: 2016-05-21T04:23:02Z
wibble
commit 178f5dcef4bb22def2b818a1dd21e5952700c0e4
Author: Mark Shields <[email protected]>
Date: 2016-05-21T05:14:54Z
Mark as bounded
commit da3bfe464f0b2b69c826d1a7d72868211b448371
Author: Mark Shields <[email protected]>
Date: 2016-05-22T01:44:47Z
Fix warnings
commit 710fd2db6100d071392dd5fba28114ebe8548065
Author: Mark Shields <[email protected]>
Date: 2016-05-22T01:47:17Z
yawn
----
> PubSubIO: reimplement in Java
> -----------------------------
>
> Key: BEAM-53
> URL: https://issues.apache.org/jira/browse/BEAM-53
> Project: Beam
> Issue Type: New Feature
> Components: runner-core
> Reporter: Daniel Halperin
> Assignee: Mark Shields
>
> PubSubIO is currently only partially implemented in Java: the
> DirectPipelineRunner uses a non-scalable API in a single-threaded manner.
> In contrast, the DataflowPipelineRunner uses an entirely different code path
> implemented in the Google Cloud Dataflow service.
> We need to reimplement PubSubIO in Java in order to support other runners in
> a scalable way.
> Additionally, we can take this opportunity to add new features:
> * getting timestamp from an arbitrary lambda in arbitrary formats rather than
> from a message attribute in only 2 formats.
> * exposing metadata and attributes in the elements produced by PubSubIO.Read
> * setting metadata and attributes in the messages written by PubSubIO.Write
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
