[
https://issues.apache.org/jira/browse/BEAM-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297137#comment-15297137
]
ASF GitHub Bot commented on BEAM-117:
-------------------------------------
GitHub user swegner opened a pull request:
https://github.com/apache/incubator-beam/pull/375
[BEAM-117] Evaluate display data from InProcessPipelineRunner
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Display data can be added to any PTransform to be used
for display from any runner. Runners are not required to
consume display data, and currently many don't.
This changes InProcessRunner to consumer display data (and then
discard it) in order to validate that display data is properly
implemented on transforms within a pipeline. Exceptions thrown
within HasDisplayData implementations will cause Pipeline.run()
to fail.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/swegner/incubator-beam
displaydata-directrunner
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/375.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #375
----
commit 698a0af1553279ba48ad2f4768556fbd4810208a
Author: Scott Wegner <[email protected]>
Date: 2016-05-23T21:29:33Z
Evaluate display data from InProcessPipelineRunner
Display data can be added to any PTransform to be used
for display from any runner. Runners are not required to
consume display data, and currently many don't.
This changes InProcessRunner to consumer display data (and then
discard it) in order to validate that display data is properly
implemented on transforms within a pipeline. Exceptions thrown
within HasDisplayData implementations will cause Pipeline.run()
to fail.
----
> Implement the API for Static Display Metadata
> ---------------------------------------------
>
> Key: BEAM-117
> URL: https://issues.apache.org/jira/browse/BEAM-117
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Ben Chambers
> Assignee: Scott Wegner
>
> As described in the following doc, we would like the SDK to allow associating
> display metadata with PTransforms.
> https://docs.google.com/document/d/11enEB9JwVp6vO0uOYYTMYTGkr3TdNfELwWqoiUg5ZxM/edit?usp=sharing
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
