[
https://issues.apache.org/jira/browse/BEAM-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297383#comment-15297383
]
ASF GitHub Bot commented on BEAM-88:
------------------------------------
GitHub user ilganeli opened a pull request:
https://github.com/apache/incubator-beam/pull/379
[BEAM-88][WIP] DataflowPipelineOptions.tempLocation doesn't really default
to stagingLocation
This is still a work in progress since it's unclear where the default
settings should **actually** be set. However, I've started by adding a unit
test that demonstrates the issue, showing that we violate the assumption that
one path is set by default.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilganeli/incubator-beam BEAM-88
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/379.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #379
----
commit 75f18d2fb2e8315198a49af3d924cbd5a0d88e16
Author: Ilya Ganelin <[email protected]>
Date: 2016-05-23T23:58:16Z
Added test to confirm default properties are set appropriately or an error
is thrown when setting either tempLocation or stagingLocation for
DataflowPipelineOptions.
----
> DataflowPipelineOptions.tempLocation doesn't really default to stagingLocation
> ------------------------------------------------------------------------------
>
> Key: BEAM-88
> URL: https://issues.apache.org/jira/browse/BEAM-88
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Eugene Kirpichov
> Priority: Trivial
>
> The documentation of DataflowPipelineOptions.tempLocation says: ..."defaults
> to using stagingLocation."...
> However calling .getTempLocation() when only --stagingLocation is specified
> on the command line gives null.
> The "defaulting" is really done in DataflowPipelineRunner.fromOptions():
> {code}
> if (Strings.isNullOrEmpty(dataflowOptions.getTempLocation())) {
> dataflowOptions.setTempLocation(dataflowOptions.getStagingLocation());
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
