GitHub user mshields822 opened a pull request:
https://github.com/apache/incubator-beam/pull/380
[BEAM-299] Fix invariant failure in MergingActiveWindowSet
The 'windowToActiveWindow' map in MergingActiveWindowSet had a confused
invariant. It was partially tracking the window-to-merged-window map needed
while processing a single bundle in ReduceFnRunner. But it was also tracking
which 'state address windows' correspond to which active windows. The
invariants were written for the second use, which was no longer correct.
This PR factors out the window-to-merged-window map into the
ReduceFnRunner and simplifies what's left.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mshields822/incubator-beam beam-299
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/380.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #380
----
commit 6fc07c9715378920b886226168faf4129354b407
Author: Mark Shields <[email protected]>
Date: 2016-05-24T00:06:48Z
Factor toBeMerged->mergeResult map out of MergingActiveWindowSet, clean it
up, and improve unit tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
