[
https://issues.apache.org/jira/browse/BEAM-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323056#comment-15323056
]
ASF GitHub Bot commented on BEAM-331:
-------------------------------------
GitHub user swegner opened a pull request:
https://github.com/apache/incubator-beam/pull/441
[BEAM-331] Make AddTimestampFn range deterministic
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
The timestamps added in the WindowedWordCount example are currently
based on when the bundles are executed, which makes the min/max bounds
non-deterministic. This change makes the range based on the
construction time.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/swegner/incubator-beam wwc-addtimestampfn
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/441.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #441
----
commit 6b1d3a7d5a4e2bb9ecb010102a7d0506cda15986
Author: Scott Wegner <sweg...@google.com>
Date: 2016-06-09T18:31:23Z
Make AddTimestampFn range deterministic
The timestamps added in the WindowedWordCount example are currently
based on when the bundles are executed, which makes the min/max bounds
non-deterministic. This change makes the range based on the
construction time.
----
> WindowedWordCount.AddTimestampFn has nondeterministic timestamp bounds
> ----------------------------------------------------------------------
>
> Key: BEAM-331
> URL: https://issues.apache.org/jira/browse/BEAM-331
> Project: Beam
> Issue Type: Bug
> Reporter: Scott Wegner
> Assignee: Scott Wegner
> Priority: Minor
>
> The timestamps added in the WindowedWordCount example are based on when the
> bundles are executed, which makes the min/max bounds non-deterministic.
> It would be more desirable to capture the min/max at construction time. We
> would like this to be able to use this as an example of adding display data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
