[
https://issues.apache.org/jira/browse/BEAM-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15332267#comment-15332267
]
ASF GitHub Bot commented on BEAM-336:
-------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/471
[BEAM-336] (roll forward) Base Passert on GroupByKey
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam
PAssert-roll-forward
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/471.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #471
----
commit 591db6f0a45b6565bdfe554dd09a2768e68a1eb9
Author: Kenneth Knowles <[email protected]>
Date: 2016-06-15T17:42:59Z
[Spark] Elide assigning windows when WindowFn is null
Previously, when translating a Window.Bound transform, the case
where the WindowFn was null was missed, resulting in a
NullPointerException.
commit eba9ddf2538d37f2c5a8875a37d9f9721ee34ea1
Author: Kenneth Knowles <[email protected]>
Date: 2016-06-08T22:07:52Z
Roll-forwards: Base PAssert on GBK instead of side inputs
Previously PAssert - hence all RunnableOnService/NeedsRunner
tests - required side input support. This created a very steep
on ramp for new runners.
GroupByKey is a bit more fundamental and most backends will be
able to group by key in the global window very quickly. So switching
the primitive used to gather all the contents of a PCollection for
assertions should make it a bit easier to get early feedback during
runner development.
----
> examples-java README is not up-to-date
> --------------------------------------
>
> Key: BEAM-336
> URL: https://issues.apache.org/jira/browse/BEAM-336
> Project: Beam
> Issue Type: Bug
> Components: examples-java
> Affects Versions: 0.1.0-incubating
> Reporter: Manu Zhang
> Assignee: Manu Zhang
> Priority: Minor
> Fix For: 0.2.0-incubating
>
>
> I found some issues when following the examples-java README
> * class name is the old "com.google.cloud.dataflow.examples.WordCount"
> * "mvn compile exec:java -pl examples" failed with "ClassNotFoundException:
> org.apache.beam.examples.WordCount"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
