[
https://issues.apache.org/jira/browse/BEAM-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15332939#comment-15332939
]
ASF GitHub Bot commented on BEAM-348:
-------------------------------------
GitHub user aaltay opened a pull request:
https://github.com/apache/incubator-beam/pull/475
[BEAM-348] Clean up usage of temp directories in _stage_extra_packages
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
* temp_dir is a required parameter, clarified the doc string
* Renamed similarly named tempdir to temp_dir and creates this new
temp directory under the temp_dir. A separate temp directory is
needed for listing only the downloaded resources at this stage.
* Removed the tempdir clean up stage. Caller is giving the tempdir
and responsible for cleaning it. Only caller (stage_job_resources)
already does this.
I ran `python setup.py test` successfully with this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aaltay/incubator-beam tempdir
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/475.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #475
----
commit 2be6b8ea514336348cbfa758ecbc5bc82d323025
Author: Ahmet Altay <[email protected]>
Date: 2016-06-16T01:10:34Z
Clean up usage of temp directories in _stage_extra_packages
* temp_dir is a required parameter, clarified the doc string
* Renamed similarly named tempdir to temp_dir and creates this new
temp directory under the temp_dir. A separate temp directory is
needed for listing only the downloaded resources at this stage.
* Removed the tempdir clean up stage. Caller is giving the tempdir
and responsible for cleaning it. Only caller (stage_job_resources)
already does this.
----
> Clean temp_dir usage in _stage_extra_packages
> ---------------------------------------------
>
> Key: BEAM-348
> URL: https://issues.apache.org/jira/browse/BEAM-348
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
> Reporter: Ahmet Altay
> Assignee: Ahmet Altay
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
