[
https://issues.apache.org/jira/browse/BEAM-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15347116#comment-15347116
]
ASF GitHub Bot commented on BEAM-191:
-------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/523
[BEAM-191] Make WindowedValue extendable and deprecated valueInEmptyWindows
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam WindowedValue
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/523.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #523
----
commit 313ac286850a974862e815c6356c0ff5e37284cd
Author: Kenneth Knowles <[email protected]>
Date: 2016-06-22T14:28:34Z
Allow other subclasses of WindowedValue
commit 20a8e96bc705fc9554fef735312df15b3c57588a
Author: Kenneth Knowles <[email protected]>
Date: 2016-06-22T14:40:38Z
Make WindowedValue like an interface, allow external implementations
commit 33614c93bc2c41225d8696c94fb917be65d3f3a7
Author: Kenneth Knowles <[email protected]>
Date: 2016-06-22T14:44:45Z
Deprecate WindowedValue.valueInEmptyWindows
----
> Remove WindowedValue.valueInEmptyWindows
> ----------------------------------------
>
> Key: BEAM-191
> URL: https://issues.apache.org/jira/browse/BEAM-191
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Minor
> Labels: windowing
>
> Even though it is acceptable to create a WindowedValue carrying no windows
> when it is a fully reified WindowedValue<T>, it doesn't really make sense:
> When it becomes an element in a PCollection that a value must exist within
> some window.
> This has led to some confusion so we should remove the API. It seems there
> are just 11 files that reference WindowedValue.valueInEmptyWindows [1] that
> mostly look like they'd be fine with the global window.
> [1]
> https://github.com/apache/incubator-beam/search?p=1&q=valueInEmptyWindows&utf8=%E2%9C%93
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
