[
https://issues.apache.org/jira/browse/BEAM-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15347523#comment-15347523
]
ASF GitHub Bot commented on BEAM-142:
-------------------------------------
GitHub user lucasallan opened a pull request:
https://github.com/apache/incubator-beam/pull/526
[BEAM-142] - BigQueryIO: don't unnecessarily initialize an ExecutorService
to validate parameters
Fixes https://issues.apache.org/jira/browse/BEAM-142
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lucasallan/incubator-beam jira-beam-142
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/526.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #526
----
commit 2345809989865635fb98d14639d9f38d2a26378a
Author: Lucas Amorim <[email protected]>
Date: 2016-06-24T01:08:16Z
[BEAM-142] - BigQueryIO: don't unnecessarily initialize an ExecutorService
to validate parameters
By default, BigQueryIO initializes a ExecutorContext, however AppEngine
doesn't allow modification of threads to be daemon
threads. These changes check if it's not running on AppEngine and sets
daemon to true.
----
> BigQueryIO: don't unnecessarily initialize an ExecutorService to validate
> parameters
> ------------------------------------------------------------------------------------
>
> Key: BEAM-142
> URL: https://issues.apache.org/jira/browse/BEAM-142
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-gcp
> Reporter: Davor Bonaci
> Priority: Minor
>
> See
> http://stackoverflow.com/questions/36142464/kicking-off-dataflow-jobs-with-app-engine-errors-with-a-securityexception-on-add
> From BigQueryIO$Write$Bound.verifyTableEmpty, we call BigQueryTableInserter,
> which unnecessarily sets up ExecutorService for this case. As a result, the
> pipeline cannot be run in the App Engine environment.
> We should fix this by avoid initialization of the ExecutorService.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
