[
https://issues.apache.org/jira/browse/BEAM-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15347681#comment-15347681
]
ASF GitHub Bot commented on BEAM-155:
-------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/527
[BEAM-155] Use only WindowFn in TriggerTester
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
This change is preparatory for separating trigger syntax from
implementation.
Previously, the whole `WindowingStrategy` was passed in, but not used.
Since the tester is really a test of the state machine, it will be moved to
runners-core alongside the trigger implementation. The requirement to provide a
`WindowingStrategy` with the original syntax is extraneous.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam TriggerTester
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/527.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #527
----
commit 2cdc2be45cd7722232b56e8fdef5670b33c337d8
Author: Kenneth Knowles <[email protected]>
Date: 2016-06-24T04:24:22Z
Use only WindowFn in TriggerTester
This change is preparatory for separating trigger syntax
from implementation.
Previously, the whole WindowingStrategy was passed in, but
not used. Since the tester is really a test of the state
machine, it will be moved to runners-core alongside the trigger
implementation. The requirement to provide a WindowingStrategy
with the original syntax is extraneous.
----
> Support asserting the contents of windows and panes in PAssert
> --------------------------------------------------------------
>
> Key: BEAM-155
> URL: https://issues.apache.org/jira/browse/BEAM-155
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Thomas Groh
> Assignee: Thomas Groh
>
> This consists of reifying the output windows and panes, and running asserts
> per-window about the contents of panes.
> This includes aggregated matching and final pane matching, e.g.
> PAssert.that(output).byOnTimePane().hasOutputElements(foo, bar);
> // For discarding mode - could have emitted (say) [spam, eggs], [spam], [],
> [sausage], []
> PAssert.that(output).byFinalPane().hasOutputElements(spam, eggs, sausage,
> spam);
> // For accumulating mode without late data
> PAssert.that(output).finalPane().containsInAnyOrder(spam, eggs, sausage,
> spam);
> // For accumulating mode with late data
> PAssert.that(output).finalPane().containsInAnyOrder(foo,
> bar).mayAlsoContain(baz, rab);
> See also:
> https://docs.google.com/document/d/1fZUUbG2LxBtqCVabQshldXIhkMcXepsbv2vuuny8Ix4/edit#
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
