[ 
https://issues.apache.org/jira/browse/BEAM-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348524#comment-15348524
 ] 

Kenneth Knowles commented on BEAM-373:
--------------------------------------

False - just a readability issue. There is a {{break}} that is never reached if 
it isn't a {{Reiterator}}.

> CoGbkResult will crash after 10,000 elements on any runner that does not 
> provide a Reiterator
> ---------------------------------------------------------------------------------------------
>
>                 Key: BEAM-373
>                 URL: https://issues.apache.org/jira/browse/BEAM-373
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Thomas Groh
>            Priority: Critical
>
> Unless I am reading this wrong, there is a hardcoded downcast to 
> {{Reiterator}} after 10,000 elements. This appears to be an assumption built 
> in from the early days. (discovered while trying to decide whether 
> {{Reiterator}} should live in the SDK or runner-core)
> I will throw together a test shortly to confirm.
> https://github.com/apache/incubator-beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/join/CoGbkResult.java#L122



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to