[ 
https://issues.apache.org/jira/browse/BEAM-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Wegner updated BEAM-409:
------------------------------
    Description: 
[FindBugs 
IS2_INCONSISTENT_SYNC|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L269]:
 Inconsistent synchronization

Applies to: 
[WindowSupplier.windows|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/WindowSupplier.java#L63].

This is a good starter bug. When fixing, please remove the corresponding 
entries from 
[findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
 and verify the build passes.

  was:
[FindBugs 
DM_NEXTINT_VIA_NEXTDOUBLE|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L209]:
 Use the nextInt method of Random rather than nextDouble to generate a random 
integer

Applies to: 
[ProxyInvocationHandler.hashCode|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/options/ProxyInvocationHandler.java#L96].
 This random value is used as a pseudo-unique value for #hashCode(), although 
the default Object.hasCode() implementation does the same thing, so this should 
be unnecessary.

This is a good starter bug. When fixing, please remove the corresponding 
entries from 
[findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
 and verify the build passes.


> Inconsistent synchronization in WindowSupplier.windows
> ------------------------------------------------------
>
>                 Key: BEAM-409
>                 URL: https://issues.apache.org/jira/browse/BEAM-409
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Priority: Minor
>              Labels: findbugs, newbie, starter
>
> [FindBugs 
> IS2_INCONSISTENT_SYNC|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L269]:
>  Inconsistent synchronization
> Applies to: 
> [WindowSupplier.windows|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/WindowSupplier.java#L63].
> This is a good starter bug. When fixing, please remove the corresponding 
> entries from 
> [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
>  and verify the build passes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to