Repository: incubator-beam Updated Branches: refs/heads/master 8147037d6 -> 1a5dd59f0
[BEAM-397] - Fixes Format string - it should use %n instead of \n It fixes format string on Coder.NonDeterministicExeption.getMessage. For more information: https://issues.apache.org/jira/browse/BEAM-397 Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/7a59d0d7 Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/7a59d0d7 Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/7a59d0d7 Branch: refs/heads/master Commit: 7a59d0d760eb2c7e074c27fb038db7fcecafab63 Parents: 8147037 Author: Lucas Amorim <[email protected]> Authored: Mon Jul 4 16:26:24 2016 -0700 Committer: Luke Cwik <[email protected]> Committed: Wed Jul 6 07:08:11 2016 -0700 ---------------------------------------------------------------------- .../build-tools/src/main/resources/beam/findbugs-filter.xml | 6 ------ .../core/src/main/java/org/apache/beam/sdk/coders/Coder.java | 4 ++-- 2 files changed, 2 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/7a59d0d7/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml ---------------------------------------------------------------------- diff --git a/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml b/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml index a871eb7..a1f0e8a 100644 --- a/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml +++ b/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml @@ -69,12 +69,6 @@ <!--Class is not derived from an Exception, even though it is named as such--> </Match> <Match> - <Class name="org.apache.beam.sdk.coders.Coder$NonDeterministicException"/> - <Method name="getMessage"/> - <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE"/> - <!--Format string should use %n rather than \n--> - </Match> - <Match> <Class name="org.apache.beam.sdk.coders.EntityCoder"/> <Method name="decode"/> <Bug pattern="RR_NOT_CHECKED"/> http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/7a59d0d7/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java index d2666f0..74af59e 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java @@ -293,8 +293,8 @@ public interface Coder<T> extends Serializable { @Override public String getMessage() { - return String.format("%s is not deterministic because:\n %s", - coder, Joiner.on("\n ").join(reasons)); + return String.format("%s is not deterministic because:%n %s", + coder, Joiner.on("%n ").join(reasons)); } } }
