[
https://issues.apache.org/jira/browse/BEAM-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368309#comment-15368309
]
ASF GitHub Bot commented on BEAM-431:
-------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/613
[BEAM-431] Add test dependency on direct runner
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
The testing of the examples themselves is done via the direct runner, so
this change adds a straightforward test scoped dependency.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam direct-java8
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/613.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #613
----
commit 7c7173033cd1ac3f8b15aa083309a9ede05ee4f4
Author: Kenneth Knowles <[email protected]>
Date: 2016-07-08T19:28:33Z
Add test dependency on direct runner
The testing of the examples themselves is done
via the direct runner, so this change adds
a straightforward test scoped dependency.
----
> Examples dependencies on runners are a bit much and not enough
> --------------------------------------------------------------
>
> Key: BEAM-431
> URL: https://issues.apache.org/jira/browse/BEAM-431
> Project: Beam
> Issue Type: Bug
> Components: examples-java
> Reporter: Kenneth Knowles
>
> The Java 7 examples directly depend on the Dataflow runner as a compile
> dependency. This should just be fixed and removed.
> The Java 8 examples have optional runtime dependencies on the Dataflow and
> Flink runners. But even optional runtime dependencies must be resolved in a
> test scope, so it is not possible to exclude these from a hermetic testing
> environment - quite annoying. And the Spark runner should be included as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
