[
https://issues.apache.org/jira/browse/BEAM-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371502#comment-15371502
]
ASF GitHub Bot commented on BEAM-389:
-------------------------------------
GitHub user peihe opened a pull request:
https://github.com/apache/incubator-beam/pull/626
[BEAM-389] Fix the uses of DelegateCoder in Combine
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peihe/incubator-beam fix-binary-combine
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/626.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #626
----
commit b13eaffbf2a2c087d4f60ae5bbe59922672d4dd2
Author: Pei He <[email protected]>
Date: 2016-07-11T20:01:24Z
Fix the uses of DelegateCoder in Combine
----
> DelegateCoder needs equals and hashCode
> ---------------------------------------
>
> Key: BEAM-389
> URL: https://issues.apache.org/jira/browse/BEAM-389
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Pei He
> Assignee: Pei He
> Priority: Minor
> Fix For: 0.2.0-incubating
>
>
> Currently, DelegateCoder inherit equals() and hashCode() from StandardCoder.
> And, it makes DelegateCoder.of(VarIntCoder) equal to
> DelegateCoder.of(BigEndianIntegerCoder).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
