[
https://issues.apache.org/jira/browse/BEAM-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371675#comment-15371675
]
ASF GitHub Bot commented on BEAM-439:
-------------------------------------
GitHub user silviulica opened a pull request:
https://github.com/apache/incubator-beam/pull/632
[BEAM-439] Remove optional args from start/finish bundle methods
@robertwb can you please take a look?
Technically we do not want to allow deferred side inputs but it is much
simple conceptually to remove
extra arguments altogether.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/silviulica/incubator-beam start_finish_no_args
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/632.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #632
----
commit d5a0ec6eb67b5d87e1557be83dbcbc07bbedf36d
Author: Silviu Calinoiu <[email protected]>
Date: 2016-07-11T21:21:44Z
Remove optional args from start/finish bundle methods
----
> The start_bundle/finish_bundle should not allow side inputs
> -----------------------------------------------------------
>
> Key: BEAM-439
> URL: https://issues.apache.org/jira/browse/BEAM-439
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
> Reporter: Silviu Calinoiu
> Assignee: Frances Perry
> Priority: Minor
>
> Allowing them will create headaches when we support streaming.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
