[
https://issues.apache.org/jira/browse/BEAM-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375716#comment-15375716
]
ASF GitHub Bot commented on BEAM-445:
-------------------------------------
GitHub user swegner opened a pull request:
https://github.com/apache/incubator-beam/pull/648
[BEAM-445] Switch to netty-tcnative uber-jar dependency
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Currently, we are using the os-maven-plugin extension to compute the
platform-specific version of the netty-tcnative dependency to use in gcp-io.
Unfortunately, netty-tcnative is a transitive dependency and all pom's which
depend on gcp-io (directly or transitively) also need to declare the
os-maven-plugin dependency.
This PR removes os-maven-plugin and it's dynamic resolution. We instead
depend on the "uber jar" version of netty-tcnative, which includes all
platform-native versions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/swegner/incubator-beam os-maven-plugin
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/648.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #648
----
commit 55ed28eb4d8305ca1968d9b012b22779814d0a44
Author: Scott Wegner <[email protected]>
Date: 2016-07-12T23:20:10Z
Remove netty-tcnative dynamic os dependency
----
> Beam-examples-java build failed through local "mvn install"
> -----------------------------------------------------------
>
> Key: BEAM-445
> URL: https://issues.apache.org/jira/browse/BEAM-445
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-gcp
> Environment: linux
> Reporter: Mark Liu
> Assignee: Daniel Halperin
> Priority: Critical
>
> Build project under beam/examples/java with command "mvn clean install
> -DskipTests" failed with following error:
> [ERROR] Failed to execute goal on project beam-examples-java: Could not
> resolve dependencies for project
> org.apache.beam:beam-examples-java:jar:0.2.0-incubating-SNAPSHOT: Could not
> transfer artifact
> io.netty:netty-tcnative-boringssl-static:jar:${os.detected.classifier}:1.1.33.Fork13
> from/to central (http://repo.maven.apache.org/maven2): Illegal character in
> path at index 138:
> http://repo.maven.apache.org/maven2/io/netty/netty-tcnative-boringssl-static/1.1.33.Fork13/netty-tcnative-boringssl-static-1.1.33.Fork13-${os.detected.classifier}.jar
> Reason: can't resolve ${os.detected.classifier} in
> beam/sdks/java/io/google-cloud-platform/pom file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
