[ https://issues.apache.org/jira/browse/BEAM-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385138#comment-15385138 ]
ASF GitHub Bot commented on BEAM-372: ------------------------------------- GitHub user chandnisingh opened a pull request: https://github.com/apache/incubator-beam/pull/695 BEAM-372 added a test that verifies if a coder consumes bytes equal t… Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- …o encoded bytes You can merge this pull request into a Git repository by running: $ git pull https://github.com/chandnisingh/incubator-beam BEAM-372 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/695.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #695 ---- commit 88f5cc326ac6e43204bea1b32b8950533f665f75 Author: Chandni Singh <chandni.si...@capitalone.com> Date: 2016-07-20T00:30:16Z BEAM-372 added a test that verifies if a coder consumes bytes equal to encoded bytes ---- > CoderProperties: Test that the coder doesn't consume more bytes than it > produces > -------------------------------------------------------------------------------- > > Key: BEAM-372 > URL: https://issues.apache.org/jira/browse/BEAM-372 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Ben Chambers > Assignee: Chandni Singh > Priority: Minor > Labels: beginner, newbie, starter > > Add a test to CoderProperties that does the following: > 1. Encode a value using the Coder in the nested context > 2. Decode the value using the Coder in the nested context > 3. Verify that the input stream wasn't requested to consume any extra bytes > (This could possibly just be an enhancement to the existing round-trip > encode/decode test) > When this fails it can lead to very difficult to debug situations in a coder > wrapped around the problematic coder. This would be an easy test that would > clearly fail *for the coder which was problematic*. -- This message was sent by Atlassian JIRA (v6.3.4#6332)