GitHub user robertwb opened a pull request:
https://github.com/apache/incubator-beam/pull/718
Change all examples and tests to use the new named apply.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertwb/incubator-beam labels
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/718.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #718
----
commit b12176d950177227cba561174557647060286121
Author: Robert Bradshaw <[email protected]>
Date: 2016-07-22T21:32:33Z
Fix multi-input named PTransforms.
Now delegate the __ror__ logic entirely for the naming wrapper.
commit e42c443d6550a2b206edc56e73cb9d52e72b47e6
Author: Robert Bradshaw <[email protected]>
Date: 2016-07-22T21:34:58Z
Move names out of transform constructors.
sed -i -r 's/[|] (\S+)[(](["'"'"'][^"'"'"']+.)(, +|([)]))/| \2 >> \1(\4/g'
Small number of tests will need to be fixed by hand.
commit 583915d185f5bec840240d7c41f0269d543f6b84
Author: Robert Bradshaw <[email protected]>
Date: 2016-07-22T22:55:26Z
Fix error messages for externally named PTransforms.
commit a138ff2bac950106da312f09d01c2b2f4566c846
Author: Ahmet Altay <[email protected]>
Date: 2016-07-22T23:03:08Z
fix pipeline test
commit 43aafcb27308f4116c527d4344be2137e8bc69b3
Author: Chamikara Jayalath <[email protected]>
Date: 2016-07-22T23:04:29Z
Fixes examples
commit f18f4f038b69a9909412c51a88f35c9da47c5363
Author: Robert Bradshaw <[email protected]>
Date: 2016-07-22T23:05:23Z
Cleanup and fix combiners_test.
commit df3511db4c811e9edd2febde2d26ada8e761e326
Author: Robert Bradshaw <[email protected]>
Date: 2016-07-22T23:07:49Z
Merge pull request #1 from aaltay/labels
fix pipeline test
commit cc5feaa96d935910b18c5955cd29db7176ac9cf2
Author: Robert Bradshaw <[email protected]>
Date: 2016-07-22T23:08:32Z
Merge pull request #2 from chamikaramj/labels
Fixes examples
commit 0a2342a7b001c71e1427c06fe49e5601d29e6f56
Author: Robert Bradshaw <[email protected]>
Date: 2016-07-22T23:24:48Z
Fix label-sensitive test.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---