[ 
https://issues.apache.org/jira/browse/BEAM-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394061#comment-15394061
 ] 

Luke Cwik commented on BEAM-474:
--------------------------------

The issue is that none of the display data tests execute the pipeline and both 
NeedsRunner and RunnableOnService say that they should execute the pipeline.

tgroh@, can you clarify what NeedsRunner was for usecase wise and whether we 
need a third annotation type?

> Tests which evaluate DisplayData but don't run a pipeline should be marked 
> @NeedsRunner not @RunnableOnService
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-474
>                 URL: https://issues.apache.org/jira/browse/BEAM-474
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Luke Cwik
>            Priority: Minor
>
> Tests which evaluate DisplayData but don't run a pipeline should be marked 
> @NeedsRunner not @RunnableOnService
> @RunnableOnService represents tests which actually execute a Pipeline while 
> @NeedsRunner represents tests that need a runner to construct the pipeline.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to