Repository: incubator-beam Updated Branches: refs/heads/master 23fa61ce0 -> 388816a80
Make Coder.NonDeterministicException extend Exception instead of Throwable Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/fc35456c Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/fc35456c Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/fc35456c Branch: refs/heads/master Commit: fc35456cabee8556f2c400ba155ab603767654f5 Parents: da31a2d Author: Chandni Singh <chandni.si...@capitalone.com> Authored: Wed Aug 3 13:10:32 2016 -0700 Committer: Kenneth Knowles <k...@google.com> Committed: Wed Aug 3 17:53:50 2016 -0700 ---------------------------------------------------------------------- .../build-tools/src/main/resources/beam/findbugs-filter.xml | 5 ----- .../core/src/main/java/org/apache/beam/sdk/coders/Coder.java | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/fc35456c/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml ---------------------------------------------------------------------- diff --git a/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml b/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml index ee55ef0..28fd0df 100644 --- a/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml +++ b/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml @@ -30,11 +30,6 @@ the issue. --> <Match> - <Class name="org.apache.beam.sdk.coders.Coder$NonDeterministicException"/> - <Bug pattern="NM_CLASS_NOT_EXCEPTION"/> - <!--[BEAM-396] Class is not derived from an Exception, even though it is named as such--> - </Match> - <Match> <Class name="org.apache.beam.sdk.coders.JAXBCoder"/> <Method name="getContext"/> <Bug pattern="DC_DOUBLECHECK"/> http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/fc35456c/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java index 74af59e..136c00a 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java @@ -260,7 +260,7 @@ public interface Coder<T> extends Serializable { * Exception thrown by {@link Coder#verifyDeterministic()} if the encoding is * not deterministic, including details of why the encoding is not deterministic. */ - public static class NonDeterministicException extends Throwable { + public static class NonDeterministicException extends Exception { private Coder<?> coder; private List<String> reasons;
