[
https://issues.apache.org/jira/browse/BEAM-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421823#comment-15421823
]
ASF GitHub Bot commented on BEAM-550:
-------------------------------------
GitHub user vikkyrk opened a pull request:
https://github.com/apache/incubator-beam/pull/833
[BEAM-550] DatastoreIO Sink as ParDo
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
- DatastoreIO doesn't have an atomic operations, making
WriteOperation#(initialize/finalize) a noop. There is no benefit for the
additional complexity the Sink API brings. Hence cleaning up those classes and
directly using a ParDo to implement Datastore writes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vikkyrk/incubator-beam vikasrk/datastore_sink
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/833.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #833
----
commit 3ad876dddbf3affe39093a748578aa5d93f7b4e0
Author: Vikas Kedigehalli <[email protected]>
Date: 2016-08-15T22:28:07Z
DatastoreIO Sink as ParDo
----
> Datastore should support writes for Unbounded PCollections
> -----------------------------------------------------------
>
> Key: BEAM-550
> URL: https://issues.apache.org/jira/browse/BEAM-550
> Project: Beam
> Issue Type: Bug
> Reporter: Vikas Kedigehalli
> Assignee: Vikas Kedigehalli
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
