GitHub user dhalperi opened a pull request:
https://github.com/apache/incubator-beam/pull/888
[Draft] Cleaner backoff utilities in Beam
We have 3 different backoff classes, which don't really have that much
different functionality. Add a single, flexible backoff implementation that can
be used to replace all three classes. Additionally, this new backoff actually
supports more functionality than any of the other three did -- you can limit
retries, cap the exponential growth of an individual backoff, and cap the
cumulative time spent in backoff; prior implementations did not allow all 3.
This also makes the parameters self-obvious (`Duration`, not
number-that-is-also-millis) where appropriate.
This initial PR should have no functional changes.
TODO:
- [ ] javadoc on FlexibleBackof
- [ ] is there a better name than "FlexibleBackoff"
?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhalperi/incubator-beam cleaner-backoff
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/888.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #888
----
commit c98304a0ca574e93303f07a8a0414269f7656be9
Author: Dan Halperin <[email protected]>
Date: 2016-08-25T05:35:26Z
FlexibleBackoff: a replacement for a variety of custom backoff
implementations
commit 3a35771deda3a022c84591b23b1c5b24958ec121
Author: Dan Halperin <[email protected]>
Date: 2016-08-25T22:27:52Z
Replace other custom BackOff implementations with FlexibleBackoff
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
