[
https://issues.apache.org/jira/browse/BEAM-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447307#comment-15447307
]
ASF GitHub Bot commented on BEAM-548:
-------------------------------------
GitHub user swegner opened a pull request:
https://github.com/apache/incubator-beam/pull/906
[BEAM-548] Fixed Combine display data
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Continuation of #847
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/swegner/incubator-beam
CombinePerKeyWithHotKeyFanout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/906.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #906
----
commit e8c708ad196645ddf5f01694e89f8d1ca651d315
Author: Ian Zhou <[email protected]>
Date: 2016-08-18T20:50:52Z
Fixed Combine display data
commit fcabbfc843be1d5eef7c34362ec697bfe5456daf
Author: Ian Zhou <[email protected]>
Date: 2016-08-19T18:26:38Z
Added DisplayData test
commit 3fc6e45425e9bcfa095803add7555710a8cef2cc
Author: Scott Wegner <[email protected]>
Date: 2016-08-19T20:32:45Z
Delegate populateDipslayData to wrapped combineFn's
commit 7ffdf23e5e0f01f6aa0a9e810b2cbd4182f8158f
Author: Ian Zhou <[email protected]>
Date: 2016-08-19T22:02:28Z
Minor changes
commit 5079a9487f6653522dc001adbba7b4f86b824345
Author: Scott Wegner <[email protected]>
Date: 2016-08-29T22:42:23Z
fixup! make KeyedCombineFn non-transient to it is available for display data
----
> Combine$PerKeyWithHotKeyFanout should propagate Display Data
> ------------------------------------------------------------
>
> Key: BEAM-548
> URL: https://issues.apache.org/jira/browse/BEAM-548
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Ben Chambers
> Assignee: Scott Wegner
> Priority: Minor
>
> When using hot key combines, we produce two anonymous CombineFn's that wrap
> the original CombineFn. These currently suppress the display data of the
> delegate, instead showing up as "Combine$PerKeyWithHotKeyFanout$1".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
