[
https://issues.apache.org/jira/browse/BEAM-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449947#comment-15449947
]
ASF GitHub Bot commented on BEAM-569:
-------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/898
> JMS IO should set maxNumRecords to Long.MAX_VALUE by default
> ------------------------------------------------------------
>
> Key: BEAM-569
> URL: https://issues.apache.org/jira/browse/BEAM-569
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-extensions
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 0.3.0-incubating
>
>
> When using JmsIO this way:
> {code}
> JmsIO.read().withConnectionFactory(connectionFactory).withQueue("queue")
> {code}
> the user expects to work in unbounded mode. However, as the {{maxNumRecords}}
> value is not set by default in {{JmsIO}}, the default value set is {{0}} (as
> it's a {{long}}). It means that the {{JmsIO.read()}} just doesn't consume any
> message and exit directly.
> IMHO, it makes sense to define the {{maxNumRecords}} value to
> {{Long.MAX_VALUE}} by default. Thanks to that, {{JmsIO.read()}} will really
> work in unbounded form.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
