ASF GitHub Bot commented on BEAM-283:

GitHub user mxm opened a pull request:


    [BEAM-283] finalize CheckpointMarks upon completed checkpoint

    See the first commit for an addition to the `UnboundedSourceWrapper` to 
call `finalizeCheckpoint()` on `CheckpointMark`s upon checkpoint completion.
    The second commits contains a potential race condition upon startup of the 
source wrapper when checkpointing is enabled.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mxm/incubator-beam BEAM-283

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #967
commit cf14e809d4a790c407ab7c3cf1c90bb436a86dc9
Author: Maximilian Michels <m...@apache.org>
Date:   2016-09-16T15:04:22Z

    [BEAM-283] finalize CheckpointMarks upon completed checkpoint

commit b82208b22adab641f3c469bef622d0a76be88d68
Author: Maximilian Michels <m...@apache.org>
Date:   2016-09-16T16:42:43Z

    fix potential NPE in checkpointing of UnboundedSourceWrapper
    This moves all the initialization code to the open() method which ensures
    that no snapshot can occur before the state has been initialized correctly.


> CheckpointMark.finalize() is not called in Flink Source Wrapper
> ---------------------------------------------------------------
>                 Key: BEAM-283
>                 URL: https://issues.apache.org/jira/browse/BEAM-283
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>            Reporter: Aljoscha Krettek
>            Assignee: Maximilian Michels

This message was sent by Atlassian JIRA

Reply via email to