[ https://issues.apache.org/jira/browse/BEAM-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553140#comment-15553140 ]
ASF GitHub Bot commented on BEAM-721: ------------------------------------- GitHub user pabloem opened a pull request: https://github.com/apache/incubator-beam/pull/1062 [BEAM-721] Fixing tox for python Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ x ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- Just testing for now. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pabloem/incubator-beam test-tox-python Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/1062.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1062 ---- commit b9fcd5f2e56d8e7eb13a8937f294b1eeb2b705b9 Author: polecito...@gmail.com <polecito...@gmail.com> Date: 2016-09-29T22:41:25Z Making sure that GcsBufferedReader implements the iterator protocol commit 2d93943fad5e8179909e21dac739e3a5ce9eab55 Author: polecito...@gmail.com <polecito...@gmail.com> Date: 2016-10-04T22:40:43Z Adding raise StopIteration to GcsBufferedReader.next commit 30c66d8919cb038fa01f7d46ed66294d51201a8f Author: polecito...@gmail.com <polecito...@gmail.com> Date: 2016-10-05T00:03:14Z Adding unit tests, and __next__ for Python 3 commit 475f7e0c475c8939cd685e2761b1bd02486ca884 Author: polecito...@gmail.com <polecito...@gmail.com> Date: 2016-10-05T00:22:19Z Fixing some lint issues in unit test commit 387f824d15b6d9caaed8d01633ca162aadef9797 Author: polecito...@gmail.com <polecito...@gmail.com> Date: 2016-10-06T00:47:52Z Improving test readability. commit 51b4e775af86891f41efdfb0136317c9724e40b7 Author: Pablo <pabl...@google.com> Date: 2016-10-06T20:44:34Z Trying to unify the TOX_HOME variable ---- > Travis CI fails to run Python tox tests on Mac > ---------------------------------------------- > > Key: BEAM-721 > URL: https://issues.apache.org/jira/browse/BEAM-721 > Project: Beam > Issue Type: Bug > Components: sdk-py > Environment: Mac > Reporter: Pablo Estrada > Assignee: Frances Perry > > Some Travis CI runs on Mac are failing because the test script can not find > tox. > See: https://travis-ci.org/apache/incubator-beam/jobs/165306424#L86 > The travis.yml file does attempt to install tox (See: > https://github.com/apache/incubator-beam/blob/python-sdk/.travis.yml#L66) > Looking at the logs, it seems that tox is available in a different directory > (/usr/local), and TOX_HOME is set to $HOME/Library/Python/2.7/bin. -- This message was sent by Atlassian JIRA (v6.3.4#6332)