GitHub user kennknowles reopened a pull request:
https://github.com/apache/incubator-beam/pull/1083
[BEAM-742] Replicate triggers to runners-core (migration step towards
conversion to AST)
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
This PR is best reviewed one commit at a time, possibly supplemented by
offline command-line `git log --stat`. It is formulated to preserve `git
praise` for the files that are on their way to `runners-core`. Intermediate
states are not expected to build or make sense.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam TriggerReactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1083.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1083
----
commit a7276dab82bfb08a944e89038f4b6ef76396292b
Author: Kenneth Knowles <[email protected]>
Date: 2016-06-24T03:05:27Z
Move triggers to runners-core
This commit is effectively a "git hint" that all the files
in runners-core are moved from prior files. The moved files
will be replaced.
commit 5edfeeb1e8ae94f32b53255c8eb494dedf5865e3
Author: Kenneth Knowles <[email protected]>
Date: 2016-06-24T03:31:10Z
Rename trigger reactors
commit 3d2da3d95b2c175ac3b01a12de2e3f62442f48e6
Author: Kenneth Knowles <[email protected]>
Date: 2016-10-12T04:35:02Z
Restore prior trigger files, for temporary compatibility
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
