Jean-Baptiste Onofré created BEAM-743:

             Summary: JdbcIO should not use getConnection() with username and 
password when using DBCP BasicDataSource
                 Key: BEAM-743
             Project: Beam
          Issue Type: Bug
          Components: sdk-java-extensions
            Reporter: Jean-Baptiste Onofré
            Assignee: Jean-Baptiste Onofré

When we use an username and password, {{JdbcIO}} uses 
{{dataSource.getConnection(username, password)}}.
However, this method is not supported by DBCP {{BasicDataSource}} (as the 
username and password are already part of the data source).

Basically, the test should be if username is not null and if datasource (user 
provided) is not null, then we use {{getConnection(username, password)}} else, 
we just use {{getConnection()}}.

This message was sent by Atlassian JIRA

Reply via email to