GitHub user jbonofre opened a pull request:

    https://github.com/apache/incubator-beam/pull/1084

    [BEAM-743] JdbcIO deals right getConnection() to use with DBCP 
BasicDataSource

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbonofre/incubator-beam 
BEAM-743-JDBCIO_DBCP_USERNAME

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1084.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1084
    
----
commit ee5a0b1445a3f3f57535471baf53146a8df66884
Author: Jean-Baptiste Onofré <jbono...@apache.org>
Date:   2016-10-12T12:23:51Z

    [BEAM-743] JdbcIO deals right getConnection() to use with DBCP 
BasicDataSource

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to