Repository: incubator-beam
Updated Branches:
  refs/heads/master 7675035be -> 4d10f86cf


Remove the deprecated PCollectionView.fromIterableInternal


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/02cfaf0c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/02cfaf0c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/02cfaf0c

Branch: refs/heads/master
Commit: 02cfaf0cc2338616da35de8403365c7d76c266d4
Parents: 1ab5d00
Author: Kenneth Knowles <k...@google.com>
Authored: Mon Oct 10 13:45:58 2016 -0700
Committer: Kenneth Knowles <k...@google.com>
Committed: Tue Oct 11 20:42:36 2016 -0700

----------------------------------------------------------------------
 .../main/java/org/apache/beam/sdk/util/PCollectionViews.java  | 6 ------
 .../main/java/org/apache/beam/sdk/values/PCollectionView.java | 7 -------
 .../org/apache/beam/sdk/testing/PCollectionViewTesting.java   | 7 -------
 3 files changed, 20 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/02cfaf0c/sdks/java/core/src/main/java/org/apache/beam/sdk/util/PCollectionViews.java
----------------------------------------------------------------------
diff --git 
a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/PCollectionViews.java 
b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/PCollectionViews.java
index 3b1fde9..83ccae8 100644
--- 
a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/PCollectionViews.java
+++ 
b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/PCollectionViews.java
@@ -458,12 +458,6 @@ public class PCollectionViews {
       return untypedViewFn;
     }
 
-    @Override
-    @Deprecated
-    public ViewT fromIterableInternal(Iterable<WindowedValue<?>> elements) {
-      return getViewFn().apply(elements);
-    }
-
     /**
      * Returns a unique {@link TupleTag} identifying this {@link 
PCollectionView}.
      *

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/02cfaf0c/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PCollectionView.java
----------------------------------------------------------------------
diff --git 
a/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PCollectionView.java 
b/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PCollectionView.java
index 0e5f594..457e78a 100644
--- 
a/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PCollectionView.java
+++ 
b/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PCollectionView.java
@@ -52,13 +52,6 @@ public interface PCollectionView<T> extends PValue, 
Serializable {
   public TupleTag<Iterable<WindowedValue<?>>> getTagInternal();
 
   /**
-   * @deprecated use {@link #getViewFn()} for now, but eventually get the 
needed information via the
-   *     side input specification on the {@link ParDo} transform.
-   */
-  @Deprecated
-  public T fromIterableInternal(Iterable<WindowedValue<?>> contents);
-
-  /**
    * @deprecated this method will be removed entirely. The {@link ViewFn} for 
a side input is an
    *     attribute of the side input's specification with a {@link ParDo} 
transform, which will
    *     obtain this specification via a package-private channel.

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/02cfaf0c/sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PCollectionViewTesting.java
----------------------------------------------------------------------
diff --git 
a/sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PCollectionViewTesting.java
 
b/sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PCollectionViewTesting.java
index ea8e0af..99fb1fb 100644
--- 
a/sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PCollectionViewTesting.java
+++ 
b/sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PCollectionViewTesting.java
@@ -245,13 +245,6 @@ public final class PCollectionViewTesting {
       return (TupleTag) tag;
     }
 
-    @SuppressWarnings({"unchecked", "rawtypes"})
-    @Override
-    @Deprecated
-    public ViewT fromIterableInternal(Iterable<WindowedValue<?>> contents) {
-      return getViewFn().apply(contents);
-    }
-
     @Override
     public ViewFn<Iterable<WindowedValue<?>>, ViewT> getViewFn() {
       // Safe cast; runners must maintain type safety

Reply via email to