[ 
https://issues.apache.org/jira/browse/BEAM-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570306#comment-15570306
 ] 

ASF GitHub Bot commented on BEAM-737:
-------------------------------------

GitHub user chamikaramj opened a pull request:

    https://github.com/apache/incubator-beam/pull/1090

    [BEAM-737][BEAM-738] Updates source API documentation to mention that 
sources should be immutable and updates existing sources accordingly

    Updates source API documentation to mention that source objects should not 
be mutated.
    
    Updates  textio._TextSource so that it does not get mutated while reading.
    
    Updates source_test_utils so that sources objects do not get cloned while 
testing. This could help to catch sources that erroneously get modified while 
reading.
    
    Adds reentrancy tests for text and Avro sources.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chamikaramj/incubator-beam 
update_boundedsource_stateless

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1090.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1090
    
----
commit 5bd56f35d597b142463b1a141e2ac219e6902fc3
Author: Chamikara Jayalath <chamik...@google.com>
Date:   2016-10-12T23:51:20Z

    Updates source API documentation to mention that source objects should not 
be mutated.
    
    Updates  textio._TextSource so that it does not get mutated while reading.
    
    Updates source_test_utils so that sources objects do not get cloned while 
testing. This could help to catch sources that erroneously get modified while 
reading.
    
    Adds reentracy tests for text and Avro sources.

----


> Update TextSource to not maintain local state
> ---------------------------------------------
>
>                 Key: BEAM-737
>                 URL: https://issues.apache.org/jira/browse/BEAM-737
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py
>            Reporter: Chamikara Jayalath
>            Assignee: Chamikara Jayalath
>
> Currently, TextSource [1] maintains a temporary buffer as local state. This 
> could be problematic if a runner implementation tries to pickle the source. 
> We could update TextSource to not maintain any temporary state.
> [1] 
> https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/io/textio.py#L32



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to