[
https://issues.apache.org/jira/browse/BEAM-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573113#comment-15573113
]
Ahmet Altay commented on BEAM-520:
----------------------------------
Ven, thank you for your interest.
A partial cleanup was already done in an earlier PR
(https://github.com/apache/incubator-beam/pull/650). Take a look at that.
Similar changes needs to happen in the remaining tests (e.g.
multiple_output_pardo_test.py). Convert as many tests/examples as possible to
the assert_that pattern and send a PR.
If you are not familiar, you can also look at Beam contribution guide
(http://beam.incubator.apache.org/contribute/contribution-guide/) for the
general workflow of working with Beam.
> Update Python SDK example tests to use assert_that
> --------------------------------------------------
>
> Key: BEAM-520
> URL: https://issues.apache.org/jira/browse/BEAM-520
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py
> Reporter: Ahmet Altay
> Priority: Minor
> Labels: starter
>
> Most of our examples use assert_that to test examples:
> https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/examples/complete/autocomplete_test.py#L38
> Some of our examples use this pattern:
> 1) Create a path(s)
> 2) Construct fake command line arguments using these paths
> 3) Construct an argparse object to parse these flags
> 4) Do the (often trivial logic)
> 5) Write to a file
> 6) Manually open and read the file
> 7) Compare results.
> https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/examples/cookbook/multiple_output_pardo_test.py
> As well as being cumbersome, this obscures the core of what is being
> illustrated and tested. As many as possible tests should be updated to use
> assert_that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
