ASF GitHub Bot commented on BEAM-596:

GitHub user tgroh opened a pull request:


    [BEAM-596] Replace DirectResult#awaitCompletion with waitUntilFinish

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License 
    This is the PipelineResult interface method, rather than the
    DirectRunner-specific method.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam wait_until_finsish

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1098
commit 851b447584015e9e0e864554d1ba507f09157eb8
Author: Thomas Groh <tg...@google.com>
Date:   2016-10-13T22:07:51Z

    Replace DirectResult#awaitCompletion with waitUntilFinish
    This is the PipelineResult interface method, rather than the
    DirectRunner-specific method.


> Support cancel() and waitUntilFinish() in DirectRunner
> ------------------------------------------------------
>                 Key: BEAM-596
>                 URL: https://issues.apache.org/jira/browse/BEAM-596
>             Project: Beam
>          Issue Type: New Feature
>          Components: runner-direct
>            Reporter: Pei He
>            Assignee: Thomas Groh

This message was sent by Atlassian JIRA

Reply via email to