[
https://issues.apache.org/jira/browse/BEAM-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583158#comment-15583158
]
Kenneth Knowles commented on BEAM-755:
--------------------------------------
I have reconsidered this.
I assert that runners-core can have {{NeedsRunner}} tests but not
{{RunnableOnService}} tests. Tests labeled {{NeedsRunner}} are tests of the
support code, not the runner, and we need to execute it via _some_ runner, in
practice the {{DirectRunner}}.
But {{RunnableOnService}} is shorthand for "tests a capability in the public
model" thus they must be in the SDK.
The only test affected by the issue here is {{SplittableParDoTest}}. The test
methods there are actually suitable to be in {{ParDoTest}} with a capability
tag {{SplittableDoFn}}.
> beam-runners-core-java RunnableOnService tests not executing
> ------------------------------------------------------------
>
> Key: BEAM-755
> URL: https://issues.apache.org/jira/browse/BEAM-755
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Luke Cwik
> Assignee: Kenneth Knowles
>
> org.apache.beam:beam-runners-core-java is not specified as an integration
> test dependency to scan within runners/pom.xml
> There is also in runners/direct-java/pom.xml where its
> org.apache.beam:beam-runners-java-core and should be
> org.apache.beam:beam-runners-core-java
> Finally, even if these dependencies are added and the typo fixed. When
> running the runnable on service integration tests, SplittableParDoTest which
> contains @RunnableOnService tests (part of runners/core-java) doesn't execute.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
